From 2f7b7977f91b80d3daf63ab736185df90fb6ce79 Mon Sep 17 00:00:00 2001 From: "Xi Chen (31st Union)" Date: Tue, 12 Jul 2022 13:37:10 -0700 Subject: [PATCH] Fix invalid ptr memset in fsr2GetPermutationBlobByIndex Fix an invalid ptr memset on empty blob case in fsr2GetPermutationBlobByIndex(), from wrong pointer indirection. This causes crashes from buffer overrun by writing and reading invalid memory. Thanks to Jason Gorski for fix. --- src/ffx-fsr2-api/dx12/shaders/ffx_fsr2_shaders_dx12.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ffx-fsr2-api/dx12/shaders/ffx_fsr2_shaders_dx12.cpp b/src/ffx-fsr2-api/dx12/shaders/ffx_fsr2_shaders_dx12.cpp index 6e74429..1ca60ce 100644 --- a/src/ffx-fsr2-api/dx12/shaders/ffx_fsr2_shaders_dx12.cpp +++ b/src/ffx-fsr2-api/dx12/shaders/ffx_fsr2_shaders_dx12.cpp @@ -388,6 +388,6 @@ FfxErrorCode fsr2GetPermutationBlobByIndex( } // return an empty blob - memset(&outBlob, 0, sizeof(Fsr2ShaderBlobDX12)); + memset(outBlob, 0, sizeof(Fsr2ShaderBlobDX12)); return FFX_OK; }