Suggestion: Snap the "Candidates" slider to integer values #3
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I would have created a pull request for this, but unfortunately my code is a mess right now. Changing line 132 in app.py from this:
candidates = gr.Slider(value=1, minimum=1, maximum=6, label="Candidates")
to this:
candidates = gr.Slider(value=1, minimum=1, maximum=6, step=1, label="Candidates")
will make the progressbar snap to increments of one.
Just a small change that might make it more user-friendly.
I'm also in the process of modifying app.py so it can process bigger text by breaking it down into chunks, similar to read.py in the original script (also works for multiple candidates). I'll try a pull request when I'm done.
Added in commit
cab32e1f45
; desu I don't think I ever actually used theCandidates
slider to see it defaults as a float, my bad.That was on my mind the other day, at the very least to add an option to split by a user-provided delimiter. I suppose if you're working on that then, I'll leave it in your hands.
EDIT: I saw you just patched the bug, testing on the latest commit now.
Okay I think I have the code working now.
However there's a problem in the latest commit where regardless of what sample and iteration values you set, it sets it to "512" during generation.
I know this is unprofessional, but I can't figure out how to create a pull request so I'm gonna do a manual "git-diff" for you.
After Line 10 add this:
from tortoise.utils.text import split_and_recombine_text
In
def inference()
, after the curly brace at line 56, delete everything in the function and replace it with this: https://pastebin.com/yS1MwQQaI can't test this on the latest commit due to the bug I mentioned above (it'll take a ridiculously long time to generate), but I've tested it on
5c876b81f3
and it works.Already ahead of you, fixed it. When I was moving handling presets, I neglected to pass those back in.
No worries, I never figured out how to anything involving PRs. I'll finagle with it.
I just realized there was an error in my code that screwed up single-candidate outputs, but you seem to have caught and fixed it.
Just one suggestion before I close this issue, adding
tortoise/voices
to.gitignore
will be convenient for people making pull requests, as it'll ignore their custom datasets.Added.
In
bf32efe503
:Line Delimiter
, with an option to do new linesIn
bc567d7263
:Thanks a lot!