updated several default configurations to not cause null/empty errors. also default samples/iterations to 16-30 ultra fast which is typically suggested. #122

Merged
mrq merged 2 commits from :save_more_user_config into master 2023-03-12 15:38:35 +07:00

I originally intended to save many more user preferences and load them every time. I settled for setting defaults that don't cause errors on some of the more egregious options.
It took a long time to find the ui.load function at the end overriding preferences from config. We can do the update at the end like that in one place, it's just a bit confusing with the way the program handles EXEC_SETTINGS being saved through args and GENERATE_SETTINGS done in different ways.

Can still do my original intent when we decide which way we wanna go about doing things.

I originally intended to save many more user preferences and load them every time. I settled for setting defaults that don't cause errors on some of the more egregious options. It took a long time to find the ui.load function at the end overriding preferences from config. We can do the update at the end like that in one place, it's just a bit confusing with the way the program handles EXEC_SETTINGS being saved through args and GENERATE_SETTINGS done in different ways. Can still do my original intent when we decide which way we wanna go about doing things.
zim33 added 1 commit 2023-03-12 14:14:42 +07:00
mrq added 1 commit 2023-03-12 15:38:19 +07:00
mrq merged commit 51f6c347fe into master 2023-03-12 15:38:35 +07:00
mrq deleted branch save_more_user_config 2023-03-12 15:38:35 +07:00

Pull request successfully merged and closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrq/ai-voice-cloning#122
There is no content yet.