mrq/ai-voice-cloning
31
74
Fork 43
Code Issues 223 Pull Requests 5 Packages Projects Releases Wiki Activity

updated several default configurations to not cause null/empty errors. also default samples/iterations to 16-30 ultra fast which is typically suggested. #122

Merged
mrq merged 2 commits from :save_more_user_config into master 2023-03-12 15:38:35 +00:00
Conversation 0 Commits 2 Files Changed 1 +9 -6
zim33 commented 2023-03-12 14:14:40 +00:00
Contributor
Copy Link

I originally intended to save many more user preferences and load them every time. I settled for setting defaults that don't cause errors on some of the more egregious options.
It took a long time to find the ui.load function at the end overriding preferences from config. We can do the update at the end like that in one place, it's just a bit confusing with the way the program handles EXEC_SETTINGS being saved through args and GENERATE_SETTINGS done in different ways.

Can still do my original intent when we decide which way we wanna go about doing things.

I originally intended to save many more user preferences and load them every time. I settled for setting defaults that don't cause errors on some of the more egregious options. It took a long time to find the ui.load function at the end overriding preferences from config. We can do the update at the end like that in one place, it's just a bit confusing with the way the program handles EXEC_SETTINGS being saved through args and GENERATE_SETTINGS done in different ways. Can still do my original intent when we decide which way we wanna go about doing things.
zim33 added 1 commit 2023-03-12 14:14:42 +00:00
mrq added 1 commit 2023-03-12 15:38:19 +00:00
mrq merged commit 51f6c347fe into master 2023-03-12 15:38:35 +00:00
mrq deleted branch save_more_user_config 2023-03-12 15:38:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
insufficient info

Need more information

  
invalid

Something is wrong

  
news

To make up for a lack of a way to provide any news-like

  
not a bug

For non-bug things

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
insufficient info
invalid
news
not a bug
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrq/ai-voice-cloning#122
No description provided.
Delete Branch ":save_more_user_config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?