mrq
/
ai-voice-cloning
31
73
Fork 42
Code Issues 221 Pull Requests 5 Packages Projects Releases Wiki Activity

Labels Milestones

fix filename generation which didn't work and overwrote existing files #341

Merged
mrq merged 1 commits from ben_mkiv/ai-voice-cloning:master into master 2023-08-24 12:30:01 +07:00
Conversation 1 Commits 1 Files Changed 1
ben_mkiv commented 2023-08-24 08:05:29 +07:00

os.path.splitext(filename)[-1][1:]

also removes the dot from the extension, therefor the old condition was always true and it didn't automatically increase the filename index if a file existed

`os.path.splitext(filename)[-1][1:]` also removes the dot from the extension, therefor the old condition was always true and it didn't automatically increase the filename index if a file existed
ben_mkiv added 1 commit 2023-08-24 08:05:34 +07:00
ben_mkiv started working 2023-08-24 08:10:09 +07:00
ben_mkiv cancelled time tracking 2023-08-24 08:10:14 +07:00
mrq merged commit 4aa240d48a into master 2023-08-24 12:30:01 +07:00
mrq commented 2023-08-24 12:30:25 +07:00
Owner

Right, I kept forgetting to try and fix it in my VALL-E inference tests.

Right, I kept forgetting to try and fix it in my VALL-E inference tests.

Pull request successfully merged and closed

The branch ben_mkiv/ai-voice-cloning:master can now be deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
insufficient info

Need more information   
invalid

Something is wrong   
news

To make up for a lack of a way to provide any news-like   
not a bug

For non-bug things   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
insufficient info
invalid
news
not a bug
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrq/ai-voice-cloning#341
There is no content yet.
Delete Branch "ben_mkiv/ai-voice-cloning:master"

Deleting a branch is permanent. It CANNOT be undone. Continue?