mrq/reactphysics3d
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not set compiler warning levels in CMakeLists.txt file

Browse Source
This commit is contained in:
Daniel Chappuis 2021-10-26 21:40:39 +02:00
parent 8561d8da3a
commit 0c3a911656
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/build-and-test.yml vendored
View File

@ -220,11 +220,12 @@ jobs:
-DRP3D_CODE_COVERAGE_ENABLED=${{ matrix.config.coverage }} \ -DRP3D_CODE_COVERAGE_ENABLED=${{ matrix.config.coverage }} \
-DCODE_COVERAGE_VERBOSE=True \ -DCODE_COVERAGE_VERBOSE=True \
-DRP3D_COMPILE_TESTS=True \ -DRP3D_COMPILE_TESTS=True \
-DCMAKE_CXX_FLAGS="-Wall -Wextra -pedantic" \
-G "${{ matrix.config.generators }}" \ -G "${{ matrix.config.generators }}" \
- name: Build - name: Build
shell: bash shell: bash
run: cmake --build build/ --config ${{ matrix.config.build_type }} run: cmake --build build/ --config ${{ matrix.config.build_type }} -DCMAKE_CXX_FLAGS="-Wall -Wextra -pedantic"
- name: Install Library on Linux/MacOS - name: Install Library on Linux/MacOS
if: ${{ !startsWith(matrix.config.os, 'windows') }} if: ${{ !startsWith(matrix.config.os, 'windows') }}
@ -259,6 +260,7 @@ jobs:
-B build_hello_world \ -B build_hello_world \
-DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} \ -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} \
-DCMAKE_EXE_LINKER_FLAGS=-no-pie \ -DCMAKE_EXE_LINKER_FLAGS=-no-pie \
-DCMAKE_CXX_FLAGS="-Wall -Wextra -pedantic" \
-G "${{ matrix.config.generators }}" -G "${{ matrix.config.generators }}"
cmake --build build_hello_world/ --config ${{ matrix.config.build_type }} cmake --build build_hello_world/ --config ${{ matrix.config.build_type }}
./build_hello_world/helloworld ./build_hello_world/helloworld

6
CMakeLists.txt
View File

@ -245,12 +245,6 @@ add_library(ReactPhysics3D::reactphysics3d ALIAS reactphysics3d)
target_compile_features(reactphysics3d PUBLIC cxx_std_11) target_compile_features(reactphysics3d PUBLIC cxx_std_11)
set_target_properties(reactphysics3d PROPERTIES CXX_EXTENSIONS OFF) set_target_properties(reactphysics3d PROPERTIES CXX_EXTENSIONS OFF)
# Compile with warning messages
target_compile_options(reactphysics3d PRIVATE
$<$<CXX_COMPILER_ID:MSVC>:/W4> # for Visual Studio
$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -pedantic> # Other compilers
)
# Library headers # Library headers
target_include_directories(reactphysics3d PUBLIC target_include_directories(reactphysics3d PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>